- 
                Notifications
    You must be signed in to change notification settings 
- Fork 545
Implement @pure-unless-callable-impure #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.1.x
Are you sure you want to change the base?
Implement @pure-unless-callable-impure #3482
Conversation
        
          
                src/PhpDoc/PhpDocNodeResolver.php
              
                Outdated
          
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be replaced by phpstan/phpdoc-parser#253
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP. = false will be removed.
| Just updated phpdoc-parser here so you can use that. | 
eddd22a    to
    f207c72      
    Compare
  
    f207c72    to
    8c756cc      
    Compare
  
    | @zonuexe any plans to move this forward? | 
| @staabm Hi, I know this branch is important but it was blocked due to my motivation. I'm going to rebase it on 2.0.x and do the necessary work. If I miss it tonight, I won't be able to start the rest of the work until next week, so it would be quicker for you to take over then. | 
| I don't want to put pressure on you. It was not clear to me whether you stopped working on it or not. I am totally fine if this takes a bit more time - thank you | 
8c756cc    to
    389c7f0      
    Compare
  
    | No problem, this is a very interesting subject for me too, so I'm happy to work on it because I realized that there are other people who are interested in it. More importantly, I'm always helped by your hard work. | 
2146ae0    to
    1cc1fad      
    Compare
  
    | Friendly ping @zonuexe, still interested in this PR ? Do you have time to finish it ? | 
| @VincentLanglet | 
adb02ca    to
    abc8cd8      
    Compare
  
    abc8cd8    to
    c4999be      
    Compare
  
    | Friendly ping @zonuexe I don't want to put pressure on you. It's just not clear to me whether you stopped working on it or not. It will unblock the phpstan/phpdoc-parser#259 pr :) | 
This PR is still a work in progress, no tests or rules have been added yet.
refs #3106, phpstan/phpstan#11100 and phpstan/phpstan#11710
closes phpstan/phpstan#11101
related issue phpstan/phpdoc-parser#253